Initial removal of dynamic with some Client refactoring #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarondglover
approved these changes
Nov 14, 2016
Closed
|
This looks like a step in the right direction. Once we get dynamics out of the picture, we can start addressing other areas! +1 from me. |
|
@thinkingserious Not sure if serious? :p |
|
Ha! That is a bug in our GitHub automator. Glad you pointed that out :) |
|
Fixed the bug. I forgot to apply the exclusions list to the case when we merge a pull request of someone internal to SendGrid. Thanks again for the heads up! |
|
@thinkingserious No problem! Glad to see you got the PR merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.